Warning: Parameter 2 to GoogleSitemapGeneratorLoader::KillFrontpagePosts() expected to be a reference, value given in /home/public/blog/wp-includes/class-wp-hook.php on line 286
Dysfunctional Programming » 2017 » February

Code review: gatekeepers vs. coaches

I wrote a list of code review guidelines for the Servo project last year. They encapsulate the feedback that we expect our project contributors to provide when reviewing code changes, but I want to explore the motivation behind them. You’ll notice that almost every step is in the form “look for X”, followed by “suggest […]